On Mon, Apr 18, 2011 at 5:15 PM, Peter Stuge peter@stuge.se wrote:
Agree with Marc - well done everyone who is sending patches already!
Please continue sending small patches like this, they are easy to review and comment on.
Hamo wrote:
+choice
- prompt "Architecture"
- default ARCH_X86
- help
- This option is used to set the architecture of Coreboot.
+config ARCH_X86
- bool "X86"
+config ARCH_ARM
- bool "ARM"
- depends on EXPERT
+endchoice
I don't think the above will work as-is. Consider the comment that was removed:
-# This option is used to set the architecture of a mainboard to X86. -# It is usually set in mainboard/*/Kconfig. -config ARCH_X86
- bool
- default n
This explains that ARCH_X86 is set by mainboards and not the user.
Going forward the question is if a new step should be added to configuration, where the user can choose the architecture they are interested in, and that will limit the list of mainboards that can be selected.
The alternative is that configuration continues to work like it does now, where all mainboards by all manufacturers are displayed, and the ARCH_* variable is set by the chosen mainboard.
The approach to add a step will require much more work changing how coreboot Kconfig works. The latter approach will be simpler. I personally think that it would be fine to not have an extra step for the user to choose architecture, that this is implicit from the mainboard.
Peter makes a very good point here. The architecture would be tied to the mainboard and by extension CPU kconfig.
Marc