Re: [coreboot] patch: v3 device tree cleanup/fixup

[Carl-Daniel Hailfinger]

On 27.10.2008 20:10, ron minnich wrote:
> Marc reviewed the v3 device tree code and we developed the set of
> cleanups/fixes.
>
> Fixup device tree code. Add/change methods as needed. This should help serengeti.
>
> Signed-off-by: Ronald G. Minnich

If you can get Marc to ack this, it is also
Acked-by: Carl-Daniel Hailfinger

I'd appreciate related fixups in the v3 design doc (or do we have to
rewrite that one anyway)?

One comment below, though it does not refer directly to your patch.

Regards,
Carl-Daniel
> Index: device/pci_rom.c
>
> --- device/pci_rom.c	(revision 953)
> +++ device/pci_rom.c	(working copy)
> @@ -108,7 +108,8 @@
>    rom_data = (struct pci_data *)((unsigned char *)rom_header +
>    			       le32_to_cpu(rom_header->data));

Am I missing something here or is the line above missing somebounds check?
> printk(BIOS_SPEW, "PCI ROM Image, Vendor %04x, Device %04x,\n",
> printk(BIOS_SPEW, "PCI ROM Image, @%p, Vendor %04x, Device %04x,\n",
> &rom_data->vendor,
>  rom_data->vendor, rom_data->device);
> if (dev->id.pci.vendor != rom_data->vendor || dev->id.pci.device != rom_data->device) {
> printk(BIOS_ERR,