Re: [LinuxBIOS] RESEND: v3 patch for console functions, and mods to lib/lar.c to support a void * parameter for running functions.

[ron minnich]

On Jan 3, 2008 10:20 AM, Carl-Daniel Hailfinger
 wrote:
> On 03.01.2008 18:50, ron minnich wrote:
> > Add a void * parameter to the LAR run functions; needed for some cases,
> > in particular CAR.
>
> I still do not like that because it works around a bug in our code. It
> should work just fine without that parameter.

I don't agree. There are limits on where the stack ends up in CAR. I
would be more comfortable having the option of starting with a new
function with a new stack once CAR is turned off.

That said, I will hold off and let others fix CAR. Let me know when it
is ready and I will test on Alix.

However, please don't fix the problem by moving the stack. You can't
relocate the stack in a general way due to things like pointers to
auto.

Thanks

ron