On Tue, Jun 25, 2019 at 1:29 PM Julius Werner jwerner@chromium.org wrote:
No we don't. We had a long discussion about multi-line comment styles some years back and I made the same argument there. ;)
you're totally right, oops! I misread the coding style again just a few days ago. Sheesh!
. I'd bet 95+% of coreboot systems run Linux afterwards, and when adding support for new platforms it's just normal that the hardware vendor has the same people working on both kernel and firmware drivers for the same component.
I'm sure you are absolutely correct here. That said, I'm starting to encounter folks from, e.g., the Rust community who find some aspects or our coding style odd. I'm expecting to see more of this. From personal experience, I can say that moving from Rust-based hypervisors, kernels, and firmware to coreboot is starting to feel a bit ... weird, and in this case, coreboot is the outlier.
But yeah, point taken that many people are working in the Linux kernel style nowadays ... OTOH, we have had our encounters with UeFi SyLe CoDe, and they could make a similar argument around code style ...
I'm still of the opinion that the addition of {} after if is a good idea. After years of Go and now Rust, seeing those unprotected bits of code after an if just scares me.
Thanks
ron