Re: [coreboot] Sockets and DIMM_SUPPORT

[Peter Stuge]

Myles Watson wrote:
> Separate sockets from RAM for some sockets.
>
> Checked with abuild -C.
>
> Signed-off-by: Myles Watson
> +++ svn/src/northbridge/amd/amdfam10/Kconfig

..
> +config DIMM_FBDIMM
> +config DIMM_DDR2
> +config DIMM_DDR3
> +config DIMM_REGISTERED

Great!
> +if DIMM_FB_DIMM
> config DIMM_SUPPORT
> hex
> default 0x0110
>
> +endif
>
> +if DIMM_DDR2
> if DIMM_REGISTERED
> config DIMM_SUPPORT
> hex
> default 0x0104
> endif
> if !DIMM_REGISTERED
> config DIMM_SUPPORT
> hex
> default 0x0004
> endif
>
> +endif

I'd prefer if this logic was in code rather than Kconfig though.

Acked-by: Peter Stuge