Re: [coreboot] [PATCH] flashrom: Improve coreboot image detection heuristic

[Peter Stuge]

On Thu, Jul 03, 2008 at 04:28:54PM +0200, Carl-Daniel Hailfinger wrote:
> if ((*walk) == 0 || ((*walk) & 0x3ff) != 0 || *walk > size ||
> *(walk - 1) > size || *(walk - 2) > size ||
> (!isprint((const char *)(bios + size - *(walk - 1))) &&
> ((const char *)(bios + size - *(walk - 1)))) ||
> (!isprint((const char *)(bios + size - *(walk - 2))) &&
> ((const char *)(bios + size - *(walk - 2))))) {

I am in total disbelief. I should probably not be wasting any more of
my time on cleanups and restructuring.

But let's discuss a technical aspect. Hhow does this new heuristic
relate to v3 larballs?

//Peter