Re: [coreboot] [commit] r6625 - trunk/src/mainboard/asrock/e350m1

[Stefan Reinauer]

* Peter Stuge  [110604 18:16]:
> Stefan Reinauer wrote:
> > > +++ trunk/src/mainboard/asrock/e350m1/romstage.c	Sat Jun  4 17:44:31 2011	(r6625)
>
> ..
> > > __outdword (0xcf8, 0x8000a3a0);
> >
> > what's the reason to not use pci_read_config32() here?
> > > +++ trunk/src/mainboard/asrock/e350m1/romstage.c	Sat Jun  4 17:44:54 2011	(r6626)
>
> ..
> > > __writemsr (0xc0010062, 0);
> >
> > why not use writemsr instead of __writemsr?
>
> This is how it looked in the previous patches committed to svn, which
> were blindly applied to asrock/e350m1 after having tested that they
> worked. Ie. blame Scott. :p

I'm not blaming anyone, I just think this should  get fixed, or at least not
repeated ;)

Blindly copy'n'pasting code is not always the answer.