On Feb 12, 2008 9:04 PM, ron minnich rminnich@gmail.com wrote:
how about taking it away from explicit bit widths? Unless the bit width of a type absolutely needs to be set, you ought to use an int or even unsigned int. Can you try it?
ron
Because the code uses int a lot more than unsigned int, I used int. There are still many places where your rule is not followed, but this works and moves in that direction.
nrv2b.c in particular could use some help. It doesn't compile if safe is defined, because of undefined variables. The input parameter len is never used either. I think that should be a separate patch.
Myles
Signed-off-by: Myles Watson myles@pel.cs.byu.edu