Re: [coreboot] [PATCH] fix UDMA settings in SB700

[Uwe Hermann]

On Thu, Oct 07, 2010 at 12:39:12AM +0200, Rudolf Marek wrote:
> Hello,
>
> Following patch enables UDMA on ALL IDE devices. The current code
> enables it only for primary master, which causes my DVD drive to
> fail under windows install
> and even after hard reset in linux (DMA seems lockup).
>
> The fix should not have any influence for Linux because the IDE driver will
> correctly reprogram this bit.
>
> This brings some attention to IDE code, to what PIO/(U)DMA  should
> we setup? Is there a sane way to assume that all IDE devices are
> capable of PIO0 and UDMA0?
>
> Maybe Seabios should do some basic setup because it can talk to discs...
>
> Signed-off-by: Rudolf Marek

Acked-by: Uwe Hermann

Uwe.