Re: [coreboot] Nokia IP530 finally fully working

[Myles Watson]

pcmcia-cardbus-driver.diff:

I think all three chips should be handled by the same file.

Then you'll only have to duplicate this structure:

+static const struct pci_driver ti_pci1420_driver __pci_driver = {
+        .ops    = &ti_pci1420_ops,
+        .vendor = PCI_VENDOR_ID_TI,
+        .device = PCI_DEVICE_ID_TI_1420,
+};

We don't normally use CONFIG values to set registers.  Should they
really be configurable?

+pci_write_config8( dev, 0x0C, CONFIG_DEC21143_CACHE_LINE_SIZE );

Thanks,
Myles