Re: [coreboot] v3 bug report: Error base address register of UART in vt1211

[ron minnich]

On Sun, Jan 11, 2009 at 10:40 PM,   wrote:
> Hi Carl,
> I find a bug need to fix in superior/via/vt1211/Stage1.c
>        rawpnp_set_iobase(dev, 2, (iobase >> 2) & 0xff);
>    should be
>        rawpnp_set_iobase(dev, 0x60, ((iobase >> 2) & 0xff)<<8);

I Understand the 0x60. I don't understand this part:
((iobase >> 2) & 0xff)<<8)

Is that correct? Not just (iobase >> 8)&0xff (although the &0xff is
not really needed)

thanks

ron