[coreboot] Newbie source commit question

[Lim, Vincent]

Hi All:

I would like to add the family10h Rev C0-C2 support to coreboot and I
just wanted to make sure I've got the procedure right.

Here are my simple chances:

Index: src/cpu/amd/model_10xxx/model_10xxx_init.c
===================================================================
--- src/cpu/amd/model_10xxx/model_10xxx_init.c  (revision 4206)
+++ src/cpu/amd/model_10xxx/model_10xxx_init.c  (working copy)
@@ -142,6 +142,10 @@
        { X86_VENDOR_AMD, 0x100f2A },
    { X86_VENDOR_AMD, 0x100f22 },
    { X86_VENDOR_AMD, 0x100f23 },
+       { X86_VENDOR_AMD, 0x100f40 },           /* RB-C0 */
+       { X86_VENDOR_AMD, 0x100F42 },           /* RB-C2 */ 
+       { X86_VENDOR_AMD, 0x100F52 },           /* BL-C2 */ 
+       { X86_VENDOR_AMD, 0x100F62 },           /* DA-C2 */ 
        { 0, 0 },
     };

Since I checkout the source as developer, I just have to do a 'svn ci
.../model_10xxx_init.c', and someone will ack my commit ?

Please let me know this is the right process...

Best Regards,

Vincent Lim
SimNow Team
Performance CoE
Central Engineering
T 512.602.1618
F 512.602.7745