Re: [coreboot] [PATCH] MS7135 fixes and updates

[Uwe Hermann]

On Wed, Apr 30, 2008 at 03:21:13PM +0000, Jonathan A. Kollasch wrote:
> Fix various issues on MSI MS7135 board.
> w83627thf is strapped to 0x4e, not 0x2e
> there's no device 9 on PCI-E x1 bus, it should be device 0
> add mptable entries for AGR slot, based on info in user manual
> enable floppy drive controller so that some legacy VGA ROMs will work
>
> Signed-off-by: Jonathan A. Kollasch

Acked-by: Uwe Hermann
>      device pnp 2e.6 off end		# non-existant or undocumented
>      device pnp 2e.7 off end		# Game, MIDI, GPIO 1, GPIO 5
>      device pnp 2e.8 off end		# GPIO 2
>      device pnp 2e.9 off end		# GPIO 3, GPIO 4
>      device pnp 2e.a off end		# ACPI
>          device pnp 2e.b on		# env monitor
>          device pnp 4e.6 off end		# unknown

LDN 6 is undocumented in the datasheet, might even not exist.
Did you test if removing the line has problematic effects? Or do you
have a reason to believe there's something on that LDN?

Uwe.