Re: [LinuxBIOS] superiotool: Use 'static const' instead of 'const static'

[Jordan Crouse]

On 24/10/07 21:57 +0200, Uwe Hermann wrote:
> See patch.
> Uwe.
>
> http://www.hermann-uwe.de  | http://www.holsham-traders.de
> http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
> Use the preferred order of 'static const' instead of 'const static'.
> This is the common style in both Linux as well as in LinuxBIOS.
>
> Signed-off-by: Uwe Hermann

Acked-by: Jordan Crouse
> Index: fintek.c
>
> --- fintek.c	(Revision 2895)
> +++ fintek.c	(Arbeitskopie)
> @@ -29,7 +29,7 @@
>
> #define FINTEK_VENDOR_ID	0x3419
>
> -const static struct superio_registers reg_table[] = {
> +static const struct superio_registers reg_table[] = {
>    {0x0106, "F71862FG", {
>    	{EOT}}},
>    {0x4103, "F71872F/FG / F71806F/FG", {	/* Same ID? Datasheet typo? */
> Index: winbond.c
> ===================================================================
> --- winbond.c	(Revision 2895)
> +++ winbond.c	(Arbeitskopie)
> @@ -36,7 +36,7 @@
> Some other Super I/Os only use bits 3..0 of 0x09 as ID.
>
> */
> -const static struct superio_registers reg_table[] = {
> +static const struct superio_registers reg_table[] = {
>    /* ID and rev[3..0] */
>    {0x527, "W83977CTF", {	/* TODO: Not yet in sensors-detect */
>    	{EOT}}},
> Index: ite.c
> ===================================================================
> --- ite.c	(Revision 2895)
> +++ ite.c	(Arbeitskopie)
> @@ -26,7 +26,7 @@
>
> #define CHIP_VERSION_REG	0x22
>
> -const static struct superio_registers reg_table[] = {
> +static const struct superio_registers reg_table[] = {
>    {0x8661, "IT8661F", {
>    	/* TODO: Needs different init sequence. */
>    	{NOLDN, NULL,
> Index: nsc.c
> ===================================================================
> --- nsc.c	(Revision 2895)
> +++ nsc.c	(Arbeitskopie)
> @@ -24,7 +24,7 @@
>  #define CHIP_ID_REG	0x20	/* Super I/O ID (SID) / family */
>  #define CHIP_REV_REG	0x27	/* Super I/O revision ID (SRID) */
>
> -const static struct superio_registers reg_table[] = {
> +static const struct superio_registers reg_table[] = {
>    {0xd0, "PC87371", {	/* From sensors-detect */
>    	{EOT}}},
>    {0xdf, "PC97371", {	/* From sensors-detect */
> Index: superiotool.c
> ===================================================================
> --- superiotool.c	(Revision 2895)
> +++ superiotool.c	(Arbeitskopie)
> @@ -170,7 +170,7 @@
>  {
>    int i, j, opt, option_index;
> const static struct option long_options[] = {
> static const struct option long_options[] = {
> {"dump",		no_argument, NULL, 'd'},
> {"verbose",		no_argument, NULL, 'V'},
> {"version",		no_argument, NULL, 'v'},
> Index: ali.c
>
> --- ali.c	(Revision 2895)
> +++ ali.c	(Arbeitskopie)
> @@ -25,7 +25,7 @@
>
> #define DEVICE_REV_REG		0x1f
>
> -const static struct superio_registers reg_table[] = {
> +static const struct superio_registers reg_table[] = {
>    /* TODO: M5113 doesn't seem to have ID registers? */
>    {0x5315, "M1535/M1535D/M1535+/M1535D+", {
>    	{NOLDN, NULL,
> Index: smsc.c
> ===================================================================
> --- smsc.c	(Revision 2895)
> +++ smsc.c	(Arbeitskopie)
> @@ -26,7 +26,7 @@
>  #define DEVICE_ID_REG   	0x20
>  #define DEVICE_REV_REG  	0x21
>
> -const static struct superio_registers reg_table[] = {
> +static const struct superio_registers reg_table[] = {
>    /* The following Super I/Os use the 0x20/0x21 ID registers. */
>    {0x0e, "LPC47N252", {	/* From sensors-detect */
>    	{EOT}}},
> Index: superiotool.h
> ===================================================================
> --- superiotool.h	(Revision 2895)
> +++ superiotool.h	(Arbeitskopie)
> @@ -100,7 +100,7 @@
>  void probe_idregs_winbond(uint16_t port);
>
> /** Table of which config ports to probe for each Super I/O family. */
> -const static struct {
> +static const struct {
>    void (*probe_idregs) (uint16_t port);
>    int ports[MAXNUMPORTS]; /* Signed, as we need EOT. */
>  } superio_ports_table[] = {
>