2 Oct
2007
2 Oct
'07
7:53 p.m.
I have used flashrom just little enough to forget that -w isn't implied, and wonder why nothing happened. This fixes the help, and says something at the end of no operations are specified. Just a little user-friendliness from your good friends at LinuxBIOS.
Jordan
--
Jordan Crouse
Systems Software Development Engineer
Advanced Micro Devices, Inc.
[FLASHROM] Fix the help, and print a message when nothing happens
The help implied that writes happen by default, which they don't. Fix
the text, and say something when we get to the bottom and nothing happened.
Signed-off-by: Jordan Crouse jordan.crouse@amd.com
Index: flashrom/flashrom.c
===================================================================
--- flashrom.orig/flashrom.c 2007-10-02 11:43:38.000000000 -0600
+++ flashrom/flashrom.c 2007-10-02 11:45:51.000000000 -0600
@@ -195,8 +195,7 @@
printf(" [-e exclude_end] [-m vendor:part] [-l file.layout] [-i imagename] [file]\n");
printf
(" -r | --read: read flash and save into file\n"
- " -w | --write: write file into flash (default when\n"
- " file is specified)\n"
+ " -w | --write: write file into flash\n"
" -v | --verify: verify flash against file\n"
" -E | --erase: erase flash device\n"
" -V | --verbose: more verbose output\n"
@@ -456,5 +455,9 @@
if (verify_it)
ret |= verify_flash(flash, buf);
+ if (!(read_it|write_it|verify_it|erase_it)) {
+ printf("No operations were specified.\n");
+ }
+
return ret;
}