Re: [LinuxBIOS] [patch 2/4] Geode LX: Norwich mainboard

[Marc Jones]

Peter Stuge wrote:
> On Wed, May 02, 2007 at 07:30:20PM +0200, Uwe Hermann wrote:
> > However, the following things should be fixed before we commit,
> > IMHO:
> >
> > All license issues.
> >
> > The commit should not break other targets
>
> Agreed. I would also really like if the whitespace breakage was
> eliminated first, but I may be puritan.
> > Also, I think we should commit all four patches in one go,
> > otherwise I'm almost certain that the build will be broken...
>
> As long as the mainboard goes in last that shouldn't be a problem.
>
> //Peter

I agree and will try to fix all of these relatively minor (but 
important) issues before we commit.
Marc