Re: [LinuxBIOS] [patch 1/4] Geode LX: CPU

[Uwe Hermann]

On Tue, May 01, 2007 at 04:48:28PM -0600, Marc Jones wrote:
> This patch adds support for the AMD Geode LX CPU.
>
> Signed-off-by: Marc Jones
> Index: LinuxBIOSv2/src/cpu/amd/model_lx/cpubug.c
>
> --- LinuxBIOSv2.orig/src/cpu/amd/model_lx/cpubug.c	2007-04-30 15:25:27.000000000 -0600
> +++ LinuxBIOSv2/src/cpu/amd/model_lx/cpubug.c	2007-05-01 12:09:15.000000000 -0600
> @@ -1,35 +1,18 @@
> +/*
> +* Copyright (C) 2007 Advanced Micro Devices
> +*/

This is not enough, sorry. The copyright being with AMD is fine, but we
need a license statement, too. Please use the common LinuxBIOS license
header in _all_ files:

http://linuxbios.org/Development_Guidelines#Common_License_Header

Thanks!

(further review of the code coming soon)

Uwe.