This patch is bad. Please back it out.
svn@coreboot.org wrote:
Modified: coreboot-v3/arch/x86/Kconfig
--- coreboot-v3/arch/x86/Kconfig 2008-08-18 13:03:43 UTC (rev 783) +++ coreboot-v3/arch/x86/Kconfig 2008-08-18 16:48:27 UTC (rev 784) @@ -93,12 +93,14 @@
config LOGICAL_CPUS hex
- depends CPU_AMD_K8
This is a wrong dependency. It does not reflect any physical dependency, nor a real dependency in the code. The opposite. It is the purpose that these variables are used throughout the code to verify the availability of certain features.
The correct way of describing this would be to set the above variable to a certain value in CPU_AMD_K8, or any related option.
default 1 help How many logical CPUs there are. Fix me.
config MAX_PHYSICAL_CPUS hex
- depends CPU_AMD_K8
dito
default 1 help Max number of physical CPUs (sockets) @@ -138,6 +140,7 @@
config SMP boolean
- depends CPU_I586 || CPU_AMD_K8
dito
default 0 help This option is used to enable certain functions to make @@ -147,7 +150,7 @@
config IOAPIC boolean
- depends ARCH_X86
- depends ARCH_X86 && CPU_AMD_K8
dito
default 0 help If you want to configure an IOAPIC, set this. @@ -216,6 +219,7 @@
config USBDEBUG_DIRECT boolean
- depends SOUTHBRIDGE_NVIDIA_MCP55
dito
default 0 help Determines if we enable USB Direct debugging. If you don't have a dongle,
Modified: coreboot-v3/device/Kconfig
--- coreboot-v3/device/Kconfig 2008-08-18 13:03:43 UTC (rev 783) +++ coreboot-v3/device/Kconfig 2008-08-18 16:48:27 UTC (rev 784) @@ -97,11 +97,13 @@
config PCI_64BIT_PREF_MEM bool "64 bit prefetchable memory addresses"
- depends CPU_AMD_K8
dito