Re: [coreboot] [PATCH] flashrom: Refactor 3COM NIC code / generic PCI code

[Uwe Hermann]

On Fri, May 15, 2009 at 06:27:07PM +0200, Carl-Daniel Hailfinger wrote:
> [Is the quoting amount OK here? I'm trying to get a feeling for minimal
> quoting. Feedback appreciated.]
>
> On 15.05.2009 17:57, Uwe Hermann wrote:
> > Refactor parts of the 3COM NIC code.
> >
> > Move the reusable PCI specific parts into pcidev.c, they'll be usable
> > for other NIC code (Realtek, VIA, ...) and also for SATA/IDE controller
> > cards as external programmers (for every PCI device which can program
> > EEPROMs basically).
> >
> > Also add print_supported_pcidevs() to show the supported PCI devices
> > (currently only NICs, soon more) in the 'flashrom -L' output.
> >
> > Signed-off-by: Uwe Hermann
>
> Acked-by: Carl-Daniel Hailfinger 
> with the changes below.

Thanks, r515.
> > +#define OK 0
> > +#define NT 1    /* Not tested */
>
> Please use PCI_OK and PCI_NT (or PCI_UNTESTED).

Done for now, though the situation with our various TESTED/UNTESTED macros
in a bit suboptimal, we should improve that in one direction or the
other sooner or later (but that's for another patch).

Uwe.