Re: [coreboot] YABEL debug broken again

[Myles Watson]

On Tue, 2 Mar 2010 16:14:17 -0700, Myles Watson  wrote:
> > > > util/x86emu/yabel/vbe.c:647: error: 'vbe_mode_info_t' has no member
> > > > named 'framebuffer_address'
> > > > make: *** [util/x86emu/yabel/vbe.o] Error 1
> > >
> > > Appears to be something wrong with the union in structure
>
> vbe_mode_info_t
> > > in vbe.c. It points to another structure vesa_mode_info_t, but I am not
> > > sure why it is not working?????
> >
> > It compiles for me with 5132, but not 5135.  You could look at the
>
> changes:
> > http://tracker.coreboot.org/trac/coreboot/changeset/5135
>
> Yes it appears that union inside of the vbe_mode_info_t structure is new.
> Is it even ok to put a union inside of a structure?

Yes.  It compiles without debug, right?

If I were you I'd comment out the debugging statements that are breaking for
you, unless you are trying to debug the vbe code.  It looks like
framebuffer_address and friends were commented out in 5135.

Thanks,
Myles