Re: [coreboot] [PATCH][v2]Consoles in lbtable

[Stefan Reinauer]

* Patrick Georgi  [080126 18:30]:
> +void add_console(struct lb_header *header, u16 consoletype)
> +{
> struct lb_record *rec;
> struct lb_console *console;
> rec = lb_new_record(header);
> console = (struct lb_console *)lb_new_record(header);
> console->tag = LB_TAG_CONSOLE;
> console->size = sizeof(*console);
> console->type = LB_TAG_CONSOLE_SERIAL8250;

Is there a reason you are hardcoding the type here, despite
passing one in add_console? ;-)
> +}

Otherwise I say

Acked-by: Stefan Reinauer

Will you implement using those table entries (at least vga and serial console)
for grub2?

Stefan