Re: [coreboot] [PATCH try 5] Reduce duplicate definition in CAR code.

[Stefan Reinauer]

On 10/7/10 11:45 PM, Warren Turkal wrote:
> I implemented the consensus method of only replacing the magic numbers
> with constants instead of pulling the lists into assembler macros in
> mtrr.h. How does this one look to everyone?
>
> Comments? Acks?
>
> Thanks,
> wt
> 8<---------------------------------
> Macros for the register addresses for the MTRR MSRs are already defined
> in include/cpu/x86/car.h. This patch uses those macros instead of
> creating a second instance of that same data.
>
> I also added a few macros to the amd mtrr.h to make the MSR naming more
> consistent.
>
> Signed-off-by: Warren Turkal

Acked-by: Stefan Reinauer