On Wed, Sep 8, 2010 at 7:53 AM, Arne Georg Gleditsch firstname.lastname@example.org wrote:
Arne Georg Gleditsch email@example.com writes:
I intend to rework the MMCONF patch to map the MMCONF area into 32-bit address space, [..]
Please find appended. This patch gets rid of the %gs magic altogether, fixes a few alignment wrinkles and sets up and registers the MMCONF area for AMD Fam10h CPUs (where selected by mainboard configuration). It removes a bit of code that proved troublesome in MMCONF setups from mcp55_early_setup_car.c, as per earlier discussion.
(The way the patch hooks add_northbridge_resources via s2912_fam10/mainboard.c replicates a well-used pattern that perhaps ought to be simplified. HAVE_NORTHBRIDGE_RESOURCES would remove otherwise empty add_mainboard_resources from a lot of mainboard.c files.)
I'm confused why you wouldn't add the resource from the northbridge code. Is there a reason to have it be a mainboard resource?
+config MMCONF_SUPPORT + bool + default y + depends on NORTHBRIDGE_AMD_AMDFAM10
You could use select for MMCONF_SUPPORT. I think it should be selected in the northbridge or in the mainboard, but not both.
Instead of adding the reserved area directly to the coreboot tables, you should add it before resource allocation and let the rest happen automatically.