On 28.05.2009 06:34, Peter Stuge wrote:
Carl-Daniel Hailfinger wrote:
- @echo -n $(SVNVERSION) >flashrom-$(VERSION)/.svnversion
That's pretty ugly.
It's the only way I saw to preserve the svn revision in the tarball
We discussed this for the 0.9.0 release and you did the commits.
Right. That way works fine for releases, but not for snapshots which are shipped by quite a lot of distributions (Debian, Gentoo, ...)
Any hints on how to fix this in a different way are appreciated.
Can the patch be applied even though it is ugly?
That is a definite no.
When creating a tarball one simply changes SVNDEF in Makefile to a string with the appropriate tarball version.
That works fine for me. Would you object to a patch which changes SVNDEF in the Makefile during export? AFAICS that would address your objections and still make packaging easier.
No tricks! And no ugly hidden files for no reason. KISS.
OK.
Regards, Carl-Daniel