OK, I think I've seen it now. The API to acpi_add_table has changed too.
It's now passed the rsdp as the root of the table structs rather than rsdt.
Shouldn't we really have an announces list to advertise fairly fundamental API changes like this ?
-----Original Message----- From: Harrison, Jon (SELEX GALILEO, UK) Sent: 06 August 2009 11:57 To: 'coreboot@coreboot.org' Subject: Recent wpdchanges to acpi_write_rsdp
Hi guys,
I've finally got my EPIA-N/CN400 port booting all of the way into linux (fc9 2.6.25)
I've been merging my latest back into a copy of the current trunk (R4506)to get patches together, but I've found that ACPI is now broken in my build.
It appear that the API to acpi_write_rsdp has changed to allow an xsdt table to be written.
I have tried including and xsdt and also setting the pointer NULL the results are both the same.
Is there some other table revision issue or perhaps alignment issue that needs to be taken care of ??
Thanks for any help. I'm on hols from tomorrow and would like to get the patch out before I go.
Before acpi_write_rsdp API change:::
High Tables Base is 3bff0000. Copying Interrupt Routing Table to 0x000f0000... done. Copying Interrupt Routing Table to 0x3bff0000... done. ACPI: Writing ACPI tables at 3bff0400... ACPI: * FACS ACPI: * DSDT ACPI: * DSDT @ 3bff04c0 Length 11fc ACPI: * FADT ACPI: added table 1/8 Length now 40 ACPI: * MADT ACPI: Creating lapic entry for CPU #0 in MADT ACPI: added table 2/8 Length now 44 ACPI: done. Wrote the mp table end at: 000f0440 - 000f0560 Wrote the mp table end at: 3bff1c10 - 3bff1d30 Moving GDT to 0x3bff2000...ok Multiboot Information structure has been written. Writing high table forward entry at 0x00000500 Wrote coreboot table at: 00000500 - 00000518 checksum 9fdf New low_table_end: 0x00000518 Now going to write high coreboot table at 0x3bff2400 rom_table_end = 0x3bff2400 Adjust low_table_end from 0x00000518 to 0x00001000 Adjust rom_table_end from 0x3bff2400 to 0x3c000000 Adding high table area Wrote coreboot table at: 3bff2400 - 3bff2ad4 checksum ad2e
After acpi_write_rsdp API change:::
High Tables Base is 3bff0000. Copying Interrupt Routing Table to 0x000f0000... done. Copying Interrupt Routing Table to 0x3bff0000... done. ACPI: Writing ACPI tables at 3bff0400... ACPI: * FACS ACPI: * DSDT ACPI: * DSDT @ 3bff04c0 Length 11fc ACPI: * FADT ACPI: Error: Could not add ACPI table, too many tables. ACPI: * MADT ACPI: Error: Could not add ACPI table, too many tables. ACPI: done. Wrote the mp table end at: 000f0440 - 000f0560 Wrote the mp table end at: 3bff1c10 - 3bff1d30 Moving GDT to 0x3bff2000...ok Multiboot Information structure has been written. Writing high table forward entry at 0x00000500 Wrote coreboot table at: 00000500 - 00000518 checksum 9fdf New low_table_end: 0x00000518 Now going to write high coreboot table at 0x3bff2400 rom_table_end = 0x3bff2400 Adjust low_table_end from 0x00000518 to 0x00001000 Adjust rom_table_end from 0x3bff2400 to 0x3c000000 Adding high table area Wrote coreboot table at: 3bff2400 - 3bff2ad4 checksum 9a77
SELEX Sensors and Airborne Systems Limited Registered Office: Sigma House, Christopher Martin Road, Basildon, Essex SS14 3EL A company registered in England & Wales. Company no. 02426132 ******************************************************************** This email and any attachments are confidential to the intended recipient and may also be privileged. If you are not the intended recipient please delete it from your system and notify the sender. You should not copy it or use it for any purpose nor disclose or distribute its contents to any other person. ********************************************************************