Re: [coreboot] [PATCH] avoid mptable move with HAVE_LOW_TABLES=0and HAVE_HIGH_TABLES=1

[Myles Watson]

> -----Original Message-----
> From: [e-mail] [mailto:[e-mail]]
> On Behalf Of Ward Vandewege
> Sent: Monday, April 27, 2009 12:15 PM
> To: [e-mail]
> Subject: [coreboot] [PATCH] avoid mptable move with HAVE_LOW_TABLES=0and
> HAVE_HIGH_TABLES=1

/* The smp table must be in 0-1K, 639K-640K, or 960K-1M */
#if HAVE_LOW_TABLES == 1
    new_low_table_end = write_smp_table(low_table_end); // low_table_end
is 0x10 at this point
#endif

This snippet is right above the one you're protecting, and this file is
getting very hard to read.  Could you move this little snippet into the
change?

+#if HAVE_LOW_TABLES == 1
+	new_low_table_end = write_smp_table(low_table_end); // low_table_end
is 0x10 at this point
         /* Don't write anything in the traditional x86 BIOS data segment,
          * for example the linux kernel smp need to use 0x467 to pass reset
vector
          * or use 0x40e/0x413 for EBDA finding...

Maybe it's safer to move the section you're protecting up into the existing
#ifdef.

Acked-by: Myles Watson

Thanks,
Myles