Re: [coreboot] [flashrom][PATCH] typo in Makefile

Selon Stefan Reinauer :
> > Hello,
> >
> > Found some typo in Makefile which was producing some "strange behaviours"
>
> while
> > compiling pciutils rule.
>
> Can you enlighten us about the strangeness of that behavior? ;-)
>
> Stefan

steph-laptop:~/Work/Flashrom/flashrom> make pciutils

Checking for pciutils and zlib... found.
steph-laptop:~/Work/Flashrom/flashrom> make pciutils

Checking for pciutils and zlib... found.
steph-laptop:~/Work/Flashrom/flashrom> cc1: erreur: .test.c : Aucun fichier ou
dossier de ce type
steph-laptop:~/Work/Flashrom/flashrom> make pciutils

Checking for pciutils and zlib... found.
steph-laptop:~/Work/Flashrom/flashrom> gcc: .test.c : Aucun fichier ou dossier
de ce type

The compiler is called like :
    @$(CC) $(CFLAGS) .test.c -o .test $(LDFLAGS) &>/dev/null &&
"&>" is not recognized as a valid token, by any shell, but more like 2 separate
ones, like "&" and ">". The same line should also be written like
    @$(CC) $(CFLAGS) .test.c -o .test $(LDFLAGS) & >/dev/null &&
or else
    @$(CC) $(CFLAGS) .test.c -o .test $(LDFLAGS) >/dev/null & &&

Regarding the fix, as discussed on #coreboot, ">&" is used to redirect both CC's
stdin and stdout to /dev/null.
    @$(CC) $(CFLAGS) .test.c -o .test $(LDFLAGS) >& /dev/null &&
> > Patch is below and in attachment.
> >
> > Make good use of it ;-)
> >
> > Stephan.
> >
> > Signed-off-by: Stephan Guilloux 
> > Index: flashrom-patch-Makefile/Makefile
> > ===================================================================
> > --- flashrom-patch-Makefile/Makefile	(révision 4171)
> > +++ flashrom-patch-Makefile/Makefile	(copie de travail)
> > @@ -65,7 +65,7 @@
> >    	   echo "struct pci_access *pacc;";	   \
> >    	   echo "int main(int argc, char **argv)"; \
> >    	   echo "{ pacc = pci_alloc(); return 0; }"; ) > .test.c )
> > @$(CC) $(CFLAGS) .test.c -o .test $(LDFLAGS) &>/dev/null &&	\
> > @$(CC) $(CFLAGS) .test.c -o .test $(LDFLAGS) >&/dev/null &&	\
> > echo "found." || ( echo "not found."; echo;		\
> > echo "Please install pciutils-devel and zlib-devel.";	\
> > echo "See README for more information."; echo;		\