Peter Stuge wrote:
I have issues with parts of this.
On Wed, Feb 13, 2008 at 10:00:21PM +0100, svn@coreboot.org wrote:
M include/device/path.h Add LPC path type, replacing SUPERIO path type, since SUPERIO is only one type of LPC. Clean up tabbing in parts of the file (cosmetic).
I think this needs more discussion.
Are all superios we want to support indeed LPC? Will that stay true?
Is the code generic enough to work for any LPC device? (Flash chip, EC, custom hardware?)
You are right. I think it should stay SuperIO.
{ ramsize = "128"; constructor = "i440bx_constructors";
- domainid = "0x8086, 0x7190";
};
Again, does this identify a new domain created by this device, or does it identify this device within the containing domain? Can we escape this ambiguity?
I don't even think this should be in the dts at all. The driver code should know which pci ids to bind to. And we are doing this already:
.ops = &i440bxemulation_pcidomainops},
These ids are repeated four times, that is at least two times too many. Yes, this device id is both a PCI device and a domain, but still.
Fully agreed.
Stefan