- What is the status of the code? Is the mainboard fully supported
(with all devices etc), or is this work in progress?
As I test ,except SATA2 ports has some problems, all work well.
- Who owns the copyright to the code? You personally, or MSI?
MSIK is a part of MSI which locate at Shanghai of China, so the copyright is MSI
Please add the usual GPL header to all files, see here http://www.linuxbios.org/Development_Guidelines#Common_License_Header for an example. For existing files which you copied and modified the orginal authors and license must also remain in the file, of course.
Should I add the header and send the patch again ?
Are the changes to these two files generic, i.e. will they work for all other mainboards LinuxBIOS supports, too? Or are they specific to this board?
Need check by yinghai Lu and Ollie .
If I read this correctly you mark all files executable, which they probably should not be. I think these lines can be safely removed from the patch.
Yes.
I would make this read CHIP_NAME("MSI MS-9185 mainboard") if my patch from http://www.linuxbios.org/pipermail/linuxbios/2006-October/016449.html get committed.
Do it freely. It is OK.
Bxshi
*****CONFIDENTIAL INFORMATION*****
This email is intended only for the use of the person or entity to whom it is addressed and contains information that may be subject to and/or may be restricted from disclosure by contract or applicable law. If you are not the intended recipient of this email, be advised that any disclosure, copy, distribution or use of the contents of this message is strictly prohibited. If you are not the intended recipient of this email, please notify the sender that you have received this in error by replying to this message. Then, please delete it from your system. Thank you.