Re: [coreboot] [PATCH] superiotool: Add register dump map for NSC 8739x

[Ulf Jordan]

On Fri, 19 Dec 2008, Micha? Miros?aw wrote:
> This adds register map based on NSC PC87392 datasheet. Tested on my
> laptop.
>
> rechot superiotool # ./superiotool
> superiotool r3784
> Found NSC PC8739x (sid=0xea, srid=0x03) at 0x2e
>
> Signed-off-by: Micha? Miros?aw

One comment below. This patch is

Acked-by: Ulf Jordan
> Index: util/superiotool/nsc.c
>
> --- util/superiotool/nsc.c	(wersja 3825)
> +++ util/superiotool/nsc.c	(kopia robocza)
> @@ -308,6 +308,42 @@
>
> /* SID[7..0]: family, SRID[7..5]: ID, SRID[4..0]: rev. */
>    {0xea, "PC8739x", {
> {NOLDN, NULL,
> 	{0x20,0x21,0x22,0x23,0x24,0x25,0x26,0x27,0x28,0x29,
> 	 0x2a,0x2b,0x2c,0x2d,0x2e,0x2f,EOT},
> 	{0xea,0x11,MISC,MISC,MISC,0x80,0x00,NANA,0x00,MISC,
> 	 0x37,RSVD,RSVD,RSVD,RSVD,RSVD,EOT}},
> {0x0, "Floppy",
> 	{0x30,0x60,0x61,0x70,0x71,0x74,0x75,0xf0,0xf1,EOT},
> 	{0x00,0x03,0xf2,0x06,0x03,0x02,0x04,0x24,0x00,EOT}},
> {0x1, "Parallel port",
> 	{0x30,0x60,0x61,0x70,0x71,0x74,0x75,0xf0,EOT},
> 	{0x00,0x02,0x78,0x07,0x02,0x04,0x04,0xf2,EOT}},
> {0x2, "COM2",

The datasheet mentions that Serial Port 2 has IR functionality, so I would 
suggest the LDN name to be "COM2 / IR".

/ulf