Re: [coreboot] [patch] v3 norwich platform updates

[Marc Jones]

ron minnich wrote:
> On Fri, Feb 22, 2008 at 5:28 PM, Marc Jones  wrote:
> > Index: coreboot-v3/mainboard/amd/norwich/Makefile
> >
> > --- coreboot-v3.orig/mainboard/amd/norwich/Makefile     2008-02-22 15:44:13.000000000 -0700
> >  +++ coreboot-v3/mainboard/amd/norwich/Makefile  2008-02-22 18:15:17.000000000 -0700
> >  @@ -28,6 +28,10 @@
> >
> > STAGE2_MAINBOARD_OBJ =
> >
> > +ifeq ($(CONFIG_PIRQ_TABLE),y)
> >  +STAGE2_MAINBOARD_OBJ += irq_tables.o
> >  +endif
>
> One suggestion? Take out the ifeq. I guess I did that in alix1c, and
> I'm going to take it out of there too.
>
> We unconditionally enable CONFIG_PIRQ_TABLE for this board, so there
> is really no need for the ifeq.
>
> That said, I'm really happy to hear it boots. I think we're close to
> deprecating v2 for all lx800 targets!
>
> Acked-by: Ronald G. Minnich
>
> thanks
>
> ron

Thanks, change made.
r619

Marc