Re: [LinuxBIOS] [PATCH] Reimplementation/fixing of CS5530/CS5530A southbridge code

[Jonathan Sturges]

On Wed, Aug 15, 2007 at 11:02:29PM -0400, Jonathan Sturges wrote:
> Thanks for the updated 5530 code!
> However, I'm having some difficulty enabling the IDE controllers when using 
> this patch.  As far as I can tell, configuration parsing doesn't appear to 
> work for new ideX_enable flags.
>
> The 'register "ide0_enable" = "1"' configuration option seemed to have no 
> effect on my 5530 system.  Even though both IDE controllers were enabled in 
> Config.lb, when I'd test the resulting image, IDE0 would be disabled and 
> IDE1 enabled.  In the end, to make it work, I changed:
> "if (conf->ide0_enable) {"
> to:
> "if ( 1 ) {"
> ...in cs5530_ide.c to get IDE0 enabled.  This forces it to work.

The placement of the ide0_enable lines is important. I think they should
_not_ be within the IDE section. Check src/mainboard/asi/mb_5blmp/Config.lb
for an example which worked for me, and please report if that fixes the
problem.

Uwe.