On Fri, Feb 22, 2008 at 4:16 PM, Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net wrote:
On 22.02.2008 23:58, Myles Watson wrote:
On Fri, Feb 22, 2008 at 3:21 PM, Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net wrote:
On 22.02.2008 22:08, Myles Watson wrote:
-----Original Message----- From: ron minnich [mailto:rminnich@gmail.com] Sent: Friday, February 22, 2008 2:00 PM To: Myles Watson Cc: Carl-Daniel Hailfinger; Coreboot Subject: Re: [coreboot] v3 config patch and lar patch
On Fri, Feb 22, 2008 at 11:20 AM, Myles Watson mylesgw@gmail.com wrote:
> The patch seems to be OK. Please wait for another ack before commit, > though.
Stefan?
This patch brings us back to where you can choose not to preparse the
ELF.
hmm, I just realized if we have this, we're going to have to repair the coreboot elf parser ... it doesn't do bss correctly.
Maybe I should make it so you have to be in expert mode to not parse the ELF.
Add a dependency on BROKEN and stick a FIXME in the coreboot ELF parser. Whoever wants to use the code is free to fix it.
How about the middle ground for now and commit this patch, which defaults to parsing the ELF, since that works. Someone who knows where the ELF parser is broken should probably insert the FIXME or fix it.
The only difference between this version and the last is that PARSE_PAYLOAD_ELF defaults to y, and doesn't depend on EXPERT.
Myles
Signed-off-by: Myles Watson mylesgw@gmail.com
The coreboot part looks OK and is Acked-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net
Rev 620. Thanks, Myles
I have not reviewed the util/lar part because the code there uses a coding style (not indentation, but structure and functions) I am not familiar with.
Regards, Carl-Daniel