Re: [coreboot] [commit] r5114 - in trunk: . src/arch/i386 src/arch/i386/lib src/lib util/romcc

[Patrick Georgi]

Am 11.02.2010 10:19, schrieb Peter Stuge:
> repository service wrote:
> > +++ trunk/util/romcc/romcc.c	Thu Feb 11 04:21:29 2010	(r5114)
>
> ..
> > 	else if (strncmp(argv[1], "-include", 10) == 0) {
>
> ..
> > 		struct filelist *old_head = include_filelist;
> > 		include_filelist = malloc(sizeof(struct filelist));
> > 		if (!include_filelist) {
> > 			die("Out of memory.\n");
> > 		}
> > 		argv++;
> > 		argc--;
> > 		include_filelist->filename = argv[1];
> > 		include_filelist->next = old_head;
>
> It seems that -included files will be compiled in reverse order by
> this? Might that be a usability issue? I could change it.

romcc already requires some reverse order, so this might already be to
match things up.

testcase:

test.c is empty
include1.h contains "#warning inc1"
include2.h contains "#warning inc2"

$ ./romcc.exe -include include1.h -include include2.h test.c
include1.h:2.0: warning:  inc1
include2.h:2.0: warning:  inc2
test.c:2.0: warning:  main
:0.0:
No functions to compile

So it does the right thing.

Patrick