Re: [coreboot] [patch] SST25VF016B (2MB) flash on m57sli (IT8716F).

[Carl-Daniel Hailfinger]

On 10.03.2008 09:05, Ronald Hoogenboom wrote:
> This patch allows direct out-of-SPI-flash boot of a Linux kernel. It
> circumvents the 512KB limitation in the IT8716f superio of memory
> mapping an SPI flash device by using a PIO method for reading the data.
> Limitation: no nrv2b support.
>
> Signed-off-by: Ronald Hoogenboom

src/stream/piorom_stream.c:
A missing license header.

src/mainboard/gigabyte/m57sli/Options.lb:
Changed to be SPI-only (rev 1.x boards will have problems).
CONFIG_VGA_ROM_RUN settings are added (does not belong into this patch).

src/lib/lzma_cb.c:

This copies the incorrect copyright header from src/lib/lzma.c. I sent a
patch to correct the copyright header (GPL v2 and later) more than half
a year ago, IIRC Uwe vetoed the change because it did not introduce the
long copyright+disclaimer header.
It would be great if you used sizeof() instead of sizeof because it
helps readability.

static unsigned char scratchpad[15980];
static CLzmaDecoderState state;
static UInt32 outSize;

All three allocations were moved from the stack to rwdata. Is this
intentional?

src/lib/lzmadecode.c:

You change the definition of RC_TEST for the normal case (different
error code). Any reason for that?

I think the big buffer for streaming LZMA decompression is not allocated
anywhere, but it's already late at night, so I may be mistaken.

Regards,
Carl-Daniel