the following patch was just integrated into master: commit 33fd183f1da7a734647fc876d607785990fc6d90 Author: Kyösti Mälkki kyosti.malkki@gmail.com Date: Tue Feb 28 01:45:44 2012 +0200
Intel cpus: apply some good programming practices in new CAR
Delete dead CAR code and whitespace fixes.
Replace cryptic 32bit hex values with existing LAPIC definitions.
Do not assume state of direction flag before "rep" instruction.
Do not load immediate values on temporary registers when not needed.
Parameter pushed on stack was not popped (or flushed) after returning from call. This is a sort-of memory leak if multiple call's are implemented the same way.
Change-Id: Ibb93e889b3a0af87b89345c462e331881e78686a Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com
See http://review.coreboot.org/643 for details.
-gerrit