On 10.04.2008 02:51, Ward Vandewege wrote:
With a lot of help from Stepan at the summit, this patch adds array parsing support to the dts, specifically for the 'unwanted_vpci' field.
The code is a bit of a hack - it matches against the field name to change interpretation to array mode. Ideally we'd add some more type information after the parsing of the dts, and use that to write out statictree.c.
The dts parsing/generation code needs some love, so I'm not too worried about the hackishness of this patch at this point. But if someone wants to improve it, be my guest :)
It's great to have working code to demonstrate an idea.
However, I strongly disagree with the hardcoding of the string "unwanted_vpci" in several places in the code. Can't you use the "must_be_cells" designation in the prop_checker_table in util/dtc/livetree.c to handle this transparently?
Regards, Carl-Daniel