On Thu, Jan 31, 2019 at 11:13 AM Kyösti Mälkki (Code Review) < gerrit@coreboot.org> wrote:
Aaron, Julius; there is a bit of dilemma with car.ld.
- We need consistent layout across PRE_RAM stages
- We want RO bootblock, unaware of (future) RW romstage requirements
- I don't like the semi-random size reserve, like done here for usbdebug
Any ideas how to from improve this? Looking at CONFIG_COMMONLIB_STORAGE and CONFIG_PAGING_IN_CACHE_AS_RAM, I am not sure if the fixed locations are always maintained properly. There is some strong assumption at least, that bootblock and romstage are built with same set of Kconfig options set.
That definitely is the assumption. Kconfigs are global and there shouldn't be guarding of entries in the car.ld linker script based on stage w.r.t. to order and size of the allocated space.
View Change https://review.coreboot.org/c/coreboot/+/31174
1 comment:
File src/arch/x86/car.ld: https://review.coreboot.org/#/c/31174/1/src/arch/x86/car.ld
Patch Set #1, Line 70: https://review.coreboot.org/#/c/31174/1/src/arch/x86/car.ld@70 . += 0x60;
yes
Done
To view, visit change 31174 https://review.coreboot.org/c/coreboot/+/31174. To unsubscribe, or for help writing mail filters, visit settings https://review.coreboot.org/settings. Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib49fca781e55619179aa8888e2d859560e050876 Gerrit-Change-Number: 31174 Gerrit-PatchSet: 2 Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 31 Jan 2019 18:13:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph siro@das-labor.org Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz Gerrit-MessageType: comment _______________________________________________ coreboot-gerrit mailing list -- coreboot-gerrit@coreboot.org To unsubscribe send an email to coreboot-gerrit-leave@coreboot.org