Re: [LinuxBIOS] [PATCH] v3: fix msm800sev early serial

[Uwe Hermann]

On Wed, Aug 29, 2007 at 09:18:47PM -0700, ron minnich wrote:
> We have to test this, so please, no acks without a test. I will try to
> test tomorrow.

Any news on this?
> thanks
>
> ron
>
> On 8/29/07, Carl-Daniel Hailfinger  wrote:
> > The ADL MSM800SEV had SERIAL_DEV hardcoded to 0x30, although it should
> > be W83627HF_SP1 which is 0x2. Fix it and replace magic constants with
> > #define.
> >
> > Signed-off-by: Carl-Daniel Hailfinger
> >
> > --- LinuxBIOSv3/mainboard/adl/msm800sev/stage1.c        (Revision 485)
> > +++ LinuxBIOSv3/mainboard/adl/msm800sev/stage1.c        (Arbeitskopie)
> > @@ -33,7 +33,8 @@
> >  #include <southbridge/amd/cs5536/cs5536.h>
> >  #include <superio/winbond/w83627hf/w83627hf.h>
> >
> > -#define SERIAL_DEV 0x30
> > +#define SERIAL_DEV W83627HF_SP1
> > +#define SERIAL_IOBASE 0x3f8
> >
> > void hardware_stage1(void)
> >  {
> > @@ -49,6 +50,6 @@
> >          * for cs5536
> >          */
> >         cs5536_disable_internal_uart();
> >   w83627hf_enable_serial(0x2e, 0x30, 0x3f8);
> >   w83627hf_enable_serial(0x2e, SERIAL_DEV, SERIAL_IOBASE);
> >   printk(BIOS_DEBUG, "Done %s\n", __FUNCTION__);
> >
> > }