Peter Stuge wrote:
On Mon, Apr 28, 2008 at 09:40:51PM +0200, Carl-Daniel Hailfinger wrote:
The rest is commited in r3274.
This was a bit too fast.
I agree. The sentiment of the patch was good, but it needed some more work, moving some functions around, I don't like chip-specific code in jedec.c, that sort-of defeats the purpose. Oh well.
This is what you, the community, should take as a task for vendor contributed patches. Feel free to improve. Obviously any piece of code in the world can be improved to fit the taste of you guys out there, this is no reason to keep improvements out of coreboot as they happen. That's the great deal of open source and version control.. ;-)