Re: [coreboot] [PATCH] v3: Move stage1 global variable management from asm to C

[Carl-Daniel Hailfinger]

On 18.08.2008 16:00, Carl-Daniel Hailfinger wrote:
> Move stage1 global variable management from asm to C. The stage0 asm
> code now unconditionally pushes an empty pointer to the stack which is a
> placeholder for the pointer to global variable storage. That pointer and
> the global variable storage are initialized in global_vars_init().

Creating global variables is now extemely easy.
> Build tested on all targets, boot tested on Qemu.
>
> NOTES:
> The code is not yet MP safe, but that's due to v3 not being MP safe in
>
> general (and the comments contradict the code regarding MP features).
> K8 code now works by accident.
>
> Signed-off-by: Carl-Daniel Hailfinger

Acked-by: Segher Boessenkool 
(on IRC)

Committed in r785.

Regards,
Carl-Daniel