Hi, Ron, We have modified the patch as you told us. Thanks. Joe -----Original Message----- From: ron minnich [mailto:rminnich@gmail.com] Sent: Wednesday, November 26, 2008 11:46 PM To: Bao, Zheng Cc: coreboot@coreboot.org; Huang, FrankR; Feng, Libo; Li, Maggie; Wang, Qingpei; Xie, Michael Subject: Re: [coreboot] Patches for ACPI support on dbm690t (RS600 and SB600) On Tue, Nov 25, 2008 at 9:18 PM, Bao, Zheng <Zheng.Bao@amd.com> wrote:
Hi, Attachment are the patches for Chipset AMD RS690, AMD SB600 and mainboard DBM690T. The following ACPI features are supported. 1. S1, S5 sleep and wake up (by power button or PS/2 keyboard/mouse). 2. AMD powernow-k8 driver. 3. Thermal configuration based on ADT7461. 4. IDE timing settings. 5. HPET timer. 6. Interrupt routing based on ACPI table.
I would request one change. When there is a HALT type error, such as this: printk_info("rs690_enable: CAN NOT FIND SB bridge, HALT!\n"); it would be best to do this instead: die("rs690_enable: CAN NOT FIND SB bridge, HALT!\n"); So, for example: printk_info("rs690_enable: CAN NOT FIND SB bridge, HALT!\n"); for (;;) ; becomes instead: die("rs690_enable: CAN NOT FIND SB bridge, HALT!\n"); /*NOTREACHED*/ The rest of this patch looks fine. If you can change the "HALT" printk_info to die, then: Acked-by: Ronald G. Minnich <rminnich@gmail.com> ron