On 01.10.2007 15:00, Ward Vandewege wrote:
On Mon, Oct 01, 2007 at 02:53:35PM +0200, Carl-Daniel Hailfinger wrote:
Unfortunately not. Hmm... you used -v (verify) instead of -V (verbose).
Woops - that's what happens when you try to do stuff before coffee.
And my patch was incomplete.
Can you try "flashrom -V -m gigabyte:m57sli" with the attached patch (against current svn) and report back?
Yes, this looks a lot better:
# ./flashrom -V -m gigabyte:m57sli Calibrating delay loop... 283M loops per second. ok No LinuxBIOS table found. Found chipset "NVIDIA MCP55": Enabling flash write... OK. Found board "GIGABYTE GA-M57SLI": Enabling flash write... Serial flash segment 0xfffe0000-0xffffffff enabled Serial flash segment 0x000e0000-0x000fffff enabled Serial flash segment 0xffee0000-0xffefffff disabled Serial flash segment 0xfff80000-0xfffeffff enabled LPC write to serial flash enabled serial flash pin 29 OK. Probing for Am29F040B, 512 KB probe_29f040b: id1 0x49, id2 0x4d Probing for Am29F016D, 2048 KB probe_29f040b: id1 0xff, id2 0xff Probing for AE49F2008, 256 KB probe_jedec: id1 0x83, id2 0x83 Probing for At29C040A, 512 KB probe_jedec: id1 0x49, id2 0x4d Probing for At29C020, 256 KB probe_jedec: id1 0x83, id2 0x83 Probing for Mx29f002, 256 KB probe_29f002: id1 0x83, id2 0x83 Probing for MX25L4005, 512 KB RDID returned c2 20 13 probe_spi: id1 0xc2, id2 0x2013 MX25L4005 found at physical address: 0xfff80000 Flash part is MX25L4005 (512 KB) OK, only ENABLING flash write, but NOT FLASHING.
Great! Can you ack/commit with the following changelog? ------------------------------------------------------------------------
This patch aims to restructure SPI flash support in a more reasonable way. It introduces a generic SPI host driver for the IT8716F Super I/O which will enable easy SPI programming without having to care for the peculiarities of the SPI host.
To activate probing for the IT8716F, you have to use the gigabyte:m57sli mainboard override. SPI support will then use the gathered SPI host data to access the SPI flash.
This has been tested sucessfully by Ward Vandewege ward@gnu.org on the GA-M57SLI v2.0, which has a MX25L4005 SPI flash part.
Signed-off-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net
------------------------------------------------------------------------
Thanks, Carl-Daniel