Re: [LinuxBIOS] [PATCH] improved SPI flash support (restructured)

[Stefan Reinauer]

* Carl-Daniel Hailfinger  [070929 04:08]:
> +#define ITE_SUPERIO_PORT1	0x2e
> +#define ITE_SUPERIO_PORT2	0x4e

This has nothing to do with the IDE. All PC SuperIOs are on 2e or 4e.
> +int probe_spi(struct flashchip *flash)
> +{
> unsigned char readarr[3];

This should be a struct imho

typedef struct spi_id {
        unsigned char vendor_id;
        unsigned short device_id;
} spi_id_t;

The driver does only probe so far, right?

what about the other SPI commands?