Nope - I was just behind with my subversion revisions (merge problems on update, that will teach me...!) Just seen the patch as finalised, thanks for that, looks good and should fix the issues seen.
I was going to refine it today, but you're way ahead of me :-) Thanks, Edwin
-----Original Message----- From: coreboot-bounces@coreboot.org [mailto:coreboot-bounces@coreboot.org] On Behalf Of Stefan Reinauer Sent: 07 June 2010 09:38 To: coreboot@coreboot.org Subject: Re: [coreboot] [PATCH] Fix geode lx VSA loading
On 6/7/10 10:30 AM, Edwin Beasant wrote:
Agreed - ax should be 0, it is only 0 in this case due to the argument passed in! Before the segment setup, but after the _registers section, an xorl %ax, %al would be appropriate. Thanks! Edwin
Did I miss one?
Stefan
-----Original Message----- From: coreboot-bounces+edwin_beasant=virtensys.com@coreboot.org [mailto:coreboot-bounces+edwin_beasant=virtensys.com@coreboot.org] On Behalf Of ron minnich Sent: 06 June 2010 05:50 To: Myles Watson Cc: Stefan Reinauer; coreboot@coreboot.org Subject: Re: [coreboot] [PATCH] Fix geode lx VSA loading
On Fri, Jun 4, 2010 at 9:53 AM, Myles Watson mylesgw@gmail.com wrote:
mov $0, %ax
use the classic: xorl %ax, %ax
ron
-- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
-- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot