Ron: I'm stealing your ack although the patch has slightly changed function naming. Corey/Tom: Does this name match what you had in mind?
Factor out Geode LX VPCI device disabling into a separate function which consumes one device at a time. This helps avoid array handling in the dts and allows us to use generic disabling infrastructure.
Signed-off-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net Acked-by: Ronald G. Minnich rminnich@gmail.com
Index: LinuxBIOSv3-unwantedvpci/southbridge/amd/cs5536/cs5536.c =================================================================== --- LinuxBIOSv3-unwantedvpci/southbridge/amd/cs5536/cs5536.c (Revision 599) +++ LinuxBIOSv3-unwantedvpci/southbridge/amd/cs5536/cs5536.c (Arbeitskopie) @@ -570,6 +570,15 @@ }
+static void hide_vpci(u32 vpci_devid) +{ + /* Hide unwanted virtual PCI device. */ + printk(BIOS_DEBUG, "Hiding VPCI device: 0x%08X\n", + vpci_devid); + outl(vpci_devid + 0x7C, 0xCF8); + outl(0xDEADBEEF, 0xCFC); +} + /** * TODO. * @@ -608,16 +617,6 @@ if (sb->enable_ide) ide_init(dev);
-#warning Add back in unwanted VPCI support -#if 0 - /* Disable unwanted virtual PCI devices. */ - for (i = 0; (i < MAX_UNWANTED_VPCI) && (0 != sb->unwanted_vpci[i]); i++) { - printk(BIOS_DEBUG, "Disabling VPCI device: 0x%08X\n", - sb->unwanted_vpci[i]); - outl(sb->unwanted_vpci[i] + 0x7C, 0xCF8); - outl(0xDEADBEEF, 0xCFC); - } -#endif printk(BIOS_SPEW, "cs5536: %s() Exit\n", __FUNCTION__); }