Re: [coreboot] [PATCH] SeaBIOS - vgahooks improvements

[Rudolf Marek]

Hi,

Just a quick jump from nice evening back to nice stuff ;)
> I thought the code would be vga chip dependent.  However, it looks
> like it depends on both the chipset and vga chip.

Well VGA is inside chipset.
> It's going to be hard to maintain cpu and chipset specific features in
> SeaBIOS.  I wonder if we can find an alternative.

For another chipsets like VX800 or CN700 it would be approx same amount of code. 
Not that bad.
> Can you provide more details on what you're seeing?  The VGA BIOS is
> calling int 155f18 and then populating a register in the vga card's
> pci config space?

Yes exactly. Its in the card registers, not a PCI space, but yes in principle.

If so, could coreboot populate the register
> directly?

No, BIOS ROM overwrites this.

Rudolf