Re: [coreboot] [PATCH] RFC - move CAR config to socket config

[Warren Turkal]

I would say that the CACHE_AS_RAM should be moved in cases where all
boards support it simply because it is not really a property of the
board at that point.

Given that, I should probably also move things like ARCH_X86 into the
socket config as well.

What do you all think?

Thanks,
wt

On Sat, Sep 25, 2010 at 11:58 PM, Patrick Georgi  wrote:
> Am 26.09.2010 08:11, schrieb Warren Turkal:
> > This patch moves one of the CAR configs to the socket from the single
> > mainboard that uses it. Would this be a reasonable cleanup to perform
> > across the tree?
>
> I like the change a lot for DCACHE_RAM_*, but I'm undecided on
> CACHE_AS_RAM - it's a simple way to determine if a board uses romcc or not.
> Also, we used to have chipsets where some boards were brought over to
> CAR and some weren't. Adding the DCACHE_RAM_* values won't hurt there,
> changing the build mode will - but given that this is a manual
> per-chipset change to the build system, I guess that could be
> accomodated for (by not migrating those chipsets, or even better, by
> moving the remaining boards to CAR)
>
> Thanks,
> Patrick