On Fri, May 16, 2008 at 03:10:10AM +0200, Stefan Reinauer wrote:
OK, I forgot what this patch does, but I'm pretty sure it's justified.
Fine. Please resend, when you figured it out.
Until then, NACK.
NAK from me too.
Looking at the patch it does not change flashrom behavior in any way:
It removes one function, sst39sf020.c:erase_sector_39sf020() It makes two functions public in flash.h It changes sst28sf040.c:erase_sector_28sf040() from static to public It adds sst28sf040.c:erase_all_sectors_28sf040()
It does not add or change calls to any of these functions, so apparently they are not used and not important at the moment.
Maybe erase_sector_39sf020() does not work. After testing, I could agree to remove it.
The static vs. public functions simply do not seem to matter. AFAIK sector erasing is never done outside the chip drivers though? I think that's a good thing.
Please try to find why these changes came about.
//Peter