On Fri, Jun 19, 2009 at 12:06:18PM +0200, Carl-Daniel Hailfinger wrote:
Acked-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net
Thanks, r607.
Index: flashrom.c
--- flashrom.c (Revision 601) +++ flashrom.c (Arbeitskopie) @@ -483,8 +483,8 @@ void usage(const char *name) { printf("usage: %s [-VfLhR] [-E|-r file|-w file|-v file] [-c chipname] [-s addr]\n"
" [-e addr] [-m [vendor:]part] [-l file] [-i image] [-p programmer] [file]\n\n",name);
" [-e addr] [-m [vendor:]part] [-l file] [-i image] ""[-p programmer] [file]\n\n", name);[file] at the end should disappear. It's not your fault, but I just noticed it. Will send a patch.
OK. Not touching it in this patch then.
+#define CHIPSET_TH "{| border="0" style="font-size: smaller"\n\ +|- bgcolor="#6699dd"\n! align="left" | Vendor\n\ +! align="left" | Southbridge\n! align="left" | PCI IDs\n\ +! align="left" | Status\n\n"
I'd really like to see const char *chipset_th instead of the #define. First, it decreases the size of the binary. Second, we are safe against unintended format strings in chipset_th (and others) if we specify them as printk arguments after the format string.
Hm, I'll try to fix that in another patch. Last time I think I ran into some weird compiler issues and gave up.
- { "ASUS", "A8NE-FM/S", "http://www.hardwareschotte.de/hardware/preise/proid_1266090/preis_ASUS+A8NE-..." },
Is that link to a pricing comparison website intentional?
Well, sort of. It was the most usable (as in: contains board specs) I was able to find back then. This is an OEM board and I couldn't find a real "vendor page" for it.
Uwe.